Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a means of filtering failures on a per-component basis (fixes #34… #36

Merged
merged 1 commit into from
May 20, 2015

Conversation

kloots
Copy link
Collaborator

@kloots kloots commented May 20, 2015

Add a means of filtering failures on a per-component basis (fixes #34). Provide a means of logging DOM element references (fixes #35).

…. Provide a means of logging DOM element references (fixes #35).
@angus-c
Copy link
Collaborator

angus-c commented May 20, 2015

Can take advantage of ES6 to clean the options code up in several places

e.g.

Instead of:

var filterFailures = (failureInfo, options) => {
  var failures = failureInfo.failures;
  var filterFn = options.filterFn &&
        options.filterFn.bind(undefined, failureInfo.name, failureInfo.id);

  if (filterFn) {
    failures = failures.filter(filterFn);
  }

  return failures;
};
var filterFailures = ({failures, name, id}, {filterFn}) => {
  var filterFn = filterFn && filterFn.bind(undefined, name, id);

  if (filterFn) {
    failures = failures.filter(filterFn);
  }

  return failures;
};

@angus-c
Copy link
Collaborator

angus-c commented May 20, 2015

merging - this can be addressed separately

angus-c added a commit that referenced this pull request May 20, 2015
Add a means of filtering failures on a per-component basis (fixes #34
@angus-c angus-c merged commit 6475a4a into master May 20, 2015
@kloots kloots deleted the add-failure-filtering branch May 21, 2015 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a means of logging DOM element references Provide a means of filtering errors
2 participants