fix: adds missing dependency @babel/runtime #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using yarn with pnp enabled enforces a correct dependency structure. While using any module that has this package as a dependency I get the following error: ``` ERROR in /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js Module not found: Error: Package "[email protected]" (via "/home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js") is trying to require the package "@babel/runtime" (via "@babel/runtime/helpers/esm/extends") without it being listed in its dependencies (react, react-dom, dom-helpers, loose-envify, prop-types, react-transition-group) @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/CSSTransition.js 1:0-58 228:43-51 @ /home/msilva/.cache/yarn/v4/npm-react-transition-group-4.1.0-7b50c0a93a6c127336187252c3c1a70eff3304ce/node_modules/react-transition-group/esm/index.js @ /home/msilva/.cache/yarn/v4/npm-@material-ui-core-4.0.2-c7a07c1d1b13b94adf479d7267b51cb682fcb279/node_modules/@material-ui/core/Slide/Slide.js ``` to fix this I added the latest version of @babel/runtime to the dependencies.
|
I believe this is a bug with our build process right now. The ESM build uses Babel runtime, while the CJS build does not. Can we sync them up? |
|
Not necessary. Missing dependency is a bug. Need just to add it. |
|
The issue is that I don't think we're intentionally applying the runtime transform here. We don't do so for the CJS build, so why should we do so for the ESM build? |
|
To not duplicate babel helpers for each module in this package. ESM thing is used for browsers. Node thing is less important. But we may do that too. |
taion
approved these changes
Jun 10, 2019
|
Ah, I see that the config for the ESM build doesn't exclude runtime. I guess that must be intentional. |
jquense
changed the title
jquense
pushed a commit
that referenced
this pull request
Jun 10, 2019
## [4.1.1](v4.1.0...v4.1.1) (2019-06-10) ### Bug Fixes * adds missing dependency [@babel](https://github.com/babel)/runtime ([#507](#507)) ([228bf5f](228bf5f))
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
johnfrench3
pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [4.1.1](reactjs/react-transition-group@v4.1.0...v4.1.1) (2019-06-10) ### Bug Fixes * adds missing dependency [@babel](https://github.com/babel)/runtime ([#507](reactjs/react-transition-group#507)) ([228bf5f](reactjs/react-transition-group@228bf5f))
patrickm68
added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [4.1.1](reactjs/react-transition-group@v4.1.0...v4.1.1) (2019-06-10) ### Bug Fixes * adds missing dependency [@babel](https://github.com/babel)/runtime ([#507](reactjs/react-transition-group#507)) ([228bf5f](reactjs/react-transition-group@228bf5f))
shaikdev2
pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [4.1.1](reactjs/react-transition-group@v4.1.0...v4.1.1) (2019-06-10) ### Bug Fixes * adds missing dependency [@babel](https://github.com/babel)/runtime ([#507](reactjs/react-transition-group#507)) ([228bf5f](reactjs/react-transition-group@228bf5f))
GreenCat1996
added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [4.1.1](reactjs/react-transition-group@v4.1.0...v4.1.1) (2019-06-10) ### Bug Fixes * adds missing dependency [@babel](https://github.com/babel)/runtime ([#507](reactjs/react-transition-group#507)) ([228bf5f](reactjs/react-transition-group@228bf5f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using yarn with pnp enabled enforces a correct dependency structure. While using any module that has this package as a dependency I get the following error:
to fix this I added the latest version of @babel/runtime to the dependencies.