fix: Fix imports to play nicely with rollup

[bencentra-toast]

Fixes #529, and a similar issues with ReactDOM.findDOMNode()

Before this change, I was getting errors with rolllup such as:

(!) Missing exports
https://rollupjs.org/guide/en#error-name-is-not-exported-by-module-
../react-transition-group/lib/esm/Transition.js
oneOfType is not exported by ../react-transition-group/node_modules/prop-types/index.js
419:    * ```
420:    */
421:   children: PropTypes.oneOfType([PropTypes.func.isRequired, PropTypes.element.isRequired]).isRequired,
                           ^
422:
423:   /**

and

[!] Error: 'findDOMNode' is not exported by ../react-transition-group/node_modules/react-dom/index.js
https://rollupjs.org/guide/en#error-name-is-not-exported-by-module-
../react-transition-group/lib/esm/ReplaceTransition.js (5:9)
3: import PropTypes from 'prop-types';
4: import React from 'react';
5: import { findDOMNode } from 'react-dom';
            ^
6: import TransitionGroup from './TransitionGroup';
7: /**
Error: 'findDOMNode' is not exported by ../react-transition-group/node_modules/react-dom/index.js
    at error (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:3598:30)
    at Module.error (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:14473:9)
    at handleMissingExport (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:14400:21)
    at Module.traceVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:14742:17)
    at ModuleScope.findVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:13444:37)
    at FunctionScope.ChildScope.findVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:4281:67)
    at ChildScope.findVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:4281:67)
    at FunctionScope.ChildScope.findVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:4281:67)
    at ChildScope.findVariable (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:4281:67)
    at Identifier.bind (/Users/bencentra/toast/git-repos/buffet/node_modules/rollup/dist/rollup.js:11247:40)

After this change, I can run my project's rollup successfully ($ NODE_ENV=production rollup -c)

Tested locally by yarn link-ing react-transition-group to my project and running yarn build before building my own project.

I don't know exactly what (if anything) changed with this package that would've caused these issues, since the lines I'm changing are over a year old. react-dom got updated 2 days ago, prop-types 6 months ago, and rollup yesterday. Maybe it's a rollup problem?

[aaalrightalrightalright]

Ah, glad you also got this @bencentra-toast, thanks!

[jquense]

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[TrySound]

You still could use it successfully. It's ok to use named imports. Here's workaround for your issue in rollup config

import * as React from 'react';
import * as ReactDOM from 'react-dom';
import * as PropTypes from 'prop-types';

export default {
  ...
  commons({
    ...,
    namedExports: {
      react: Object.keys(React),
      'react-dom': Object.keys(ReactDOM),
      'prop-types': Object.keys(PropTypes)
    }
  })
  ...
}

[aaalrightalrightalright]

@TrySound, thanks for the workaround - good to note for other cases similar to this that can pop up in the wild, until expected and consistent usage can be applied like this.

[TrySound]

Well, named exports makes more sense in case of react. This workaround exist until react will provide esm support. Default export will probably be dropped eventually.