Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support currentLag() in doOnConsumer #333

Closed
gzahl opened this issue Mar 30, 2023 · 1 comment · Fixed by #365
Closed

Support currentLag() in doOnConsumer #333

gzahl opened this issue Mar 30, 2023 · 1 comment · Fixed by #365
Labels
type/enhancement A general enhancement
Milestone
1.3.22

Comments

@gzahl
Copy link

gzahl commented Mar 30, 2023

I wanted to use "consumer.currentLag(..)" with doOnConsumer and was just preparing a merge request, when i noticed that reactor-kafka is still using a 2.8 kafka-client.
Is there a rationale for this? Could we update it?
Can we still extend the ConsumerHandler to allow using "currentLag"? That would be very usefull.
Thanks!
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Mar 30, 2023
@garyrussell garyrussell added good first issue Ideal for a new contributor, we'll help type/dependency-upgrade A dependency upgrade and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Mar 30, 2023
@garyrussell garyrussell added this to the Backlog milestone Mar 30, 2023
@garyrussell
Copy link
Contributor

garyrussell commented Mar 30, 2023 •
edited
Loading

Yes, it can be upgraded, but other changes might be required and we would likely need to use reflection to maintain backwards compatibility. Unless we go to a new version (1.4 or 2.0).

Contributions are welcome.

@jrhino97 jrhino97 mentioned this issue Oct 7, 2023
Merged
@garyrussell garyrussell added type/enhancement A general enhancement and removed good first issue Ideal for a new contributor, we'll help type/dependency-upgrade A dependency upgrade labels Oct 18, 2023
@garyrussell garyrussell modified the milestones: Backlog, 1.3.22 Oct 18, 2023
garyrussell added a commit to garyrussell/reactor-kafka that referenced this issue Oct 18, 2023
@garyrussell
reactorGH-333: Support currentLag() in doOnConsumer
2c72ed6 
Resolves reactor#333
@garyrussell garyrussell mentioned this issue Oct 18, 2023
Merged
artembilan pushed a commit that referenced this issue Oct 18, 2023
@garyrussell
GH-333: Support currentLag() in doOnConsumer
1a44d5c 
Resolves #333
@garyrussell garyrussell changed the title Update kafka-client to version > 3.0 Support currentLag() in doOnConsumer Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.3.22
Development

Successfully merging a pull request may close this issue.

GH-333: Support currentLag() in doOnConsumer garyrussell/reactor-kafka
3 participants
@gzahl @garyrussell @reactorbot