Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#360 | Nikhil | Correcting reference doc format error in "Sample Scen… #362

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

nikhilkarve
Copy link
Contributor

Hi Team, I have corrected the reference doc format error in "Sample Scenarios" header. Please review.

@pivotal-cla
Copy link

@nikhilkarve Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@nikhilkarve Thank you for signing the Contributor License Agreement!

@nikhilkarve
Copy link
Contributor Author

Also would it be possible to add a label to this PR - hacktober-accepted . Would help a lot. Thank you! @artembilan

Copy link
Contributor

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this PR according to our commit policies.
Thank you for contribution!

No, we are not going to add any custom labels to the PR: that is out of our support.

@artembilan artembilan merged commit 1c25a8e into reactor:main Oct 16, 2023
@nikhilkarve
Copy link
Contributor Author

Sure no problem! Thank you, would be more than happy to contribute whenever possible. I am currently learning Kafka, and we are using it in a Spring application at work. I am loving it. Any suggestions or resources on how shall I progress on learning Kafka? Any project suggestions I should try building or anything on the similar lines? I know you must be busy, but any pointer in the right direction would help!

@artembilan
Copy link
Contributor

Not sure why is the question.
All the info and learning materials about Spring are on our official web site: https://spring.io/

@nikhilkarve
Copy link
Contributor Author

I understand the question was pretty vague. Anyways, thank you! It was my first contribution in the open source world. Have a great day.

@violetagg violetagg added this to the 1.3.22 milestone Nov 14, 2023
@violetagg violetagg added the type/documentation A documentation update label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants