Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeoutConnector decorator #51

Merged
merged 2 commits into from
Nov 20, 2016
Merged

Conversation

clue
Copy link
Contributor

@clue clue commented Nov 19, 2015

Uses promise cancellation to cancel pending connection attempts after the timer expired.

This means the exposed interface should already work, but the underlying socket resources will not currently be cleaned up in time. As such, it probably makes sense to postpone this until #40 is in. Hence marking this as WIP for now. Edit: See #71

Closes #28, supersedes/closes #10

@WyriHaximus
Copy link
Contributor

LGTM 👍

@clue clue changed the title [WIP] Add TimeoutConnector decorator Add TimeoutConnector decorator Nov 15, 2016
@clue clue added this to the v0.5.1 milestone Nov 15, 2016
@clue
Copy link
Contributor Author

clue commented Nov 15, 2016

This is now ready for review :shipit:

Copy link
Contributor

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is a really useful decorator 👍

@clue clue merged commit 3242509 into reactphp-legacy:master Nov 20, 2016
clue added a commit that referenced this pull request Nov 20, 2016
Add TimeoutConnector decorator
@clue clue deleted the timeout branch December 5, 2016 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout support (connect and execution)
3 participants