Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHPUnit 6 #112

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Support PHPUnit 6 #112

merged 1 commit into from
Nov 15, 2017

Conversation

carusogabriel
Copy link
Contributor

As we've done through severals Reactphp repos, I added support to PHPUnit 6 to this one.

WyriHaximus
WyriHaximus approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clue clue added this to the v0.5.7 milestone Nov 15, 2017
clue
clue approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this, changes LGTM! :shipit:

@clue clue merged commit d779a3b into reactphp:master Nov 15, 2017
@carusogabriel carusogabriel deleted the phpunit branch November 15, 2017 12:04
@clue clue mentioned this pull request Feb 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @jsor @WyriHaximus @clue