Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout: scroll the menu when there is too many versions #121

Closed
humitos opened this issue Sep 11, 2023 · 4 comments · Fixed by #126
Closed

Flyout: scroll the menu when there is too many versions #121

humitos opened this issue Sep 11, 2023 · 4 comments · Fixed by #126
Assignees
@zanderle
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Sep 11, 2023

Peek 2023-09-11 15-33

Related: readthedocs/readthedocs.org#7375
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Sep 11, 2023
@humitos humitos mentioned this issue Sep 11, 2023
Closed
@zanderle
Copy link
Collaborator

Do we also want to make the header of the flyout sticky, so that it is always shown, even when we scroll down?

@zanderle zanderle mentioned this issue Sep 13, 2023
Merged
@humitos
Copy link
Member Author

humitos commented Sep 13, 2023

Do we also want to make the header of the flyout sticky, so that it is always shown, even when we scroll down?

Yes. That would be great 👍🏼

humitos added a commit that referenced this issue Sep 14, 2023
@zanderle @humitos
Flyout: scroll and max-height (#126)
5b5e721 
Closes #121

---------

Co-authored-by: Manuel Kaufmann <[email protected]>
@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Sep 14, 2023
@zanderle
Copy link
Collaborator

zanderle commented Sep 14, 2023 •
edited
Loading

Do we also want to make the header of the flyout sticky, so that it is always shown, even when we scroll down?

Yes. That would be great 👍🏼

Oops, that PR (#126) didn't include this yet. Do you want me to reopen this or create a separate issue?

@humitos
Copy link
Member Author

humitos commented Sep 14, 2023

@zanderle a separate issue is fine.

@zanderle zanderle mentioned this issue Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanderle zanderle

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
✨ Addons
Status: Done
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flyout: scroll and max-height readthedocs/addons
2 participants
@humitos @zanderle