Test: EthicalAds HTML content checks #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `#ethical-ad-placement` explicit placement on Read the Docs to keep backward compatibility with current integrations. Users just need to define a `div` whenever they want in the HTML and style with the CSS classes they want as follows: ``` <div id="ethical-ad-placement" class="ad-flat"></div> ``` This will tell our EthicalAdsAddon to load the ad in that position. Note that `data-ea-manual="true"` should not be used on these cases. Closes readthedocs/meta#132
Initial tests for auto-injected ad placement.
…hedocs-client into humitos/ethicalads-html-tests
agjohnson
approved these changes
Nov 16, 2023
… humitos/ethicalads-html-tests
We were calling `placement.setAttribute()` on a `null` value :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial tests for auto-injected ad placement.