Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for old integration #429

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 11, 2024

We are not injecting readthedocs-doc-embed.js anymore and it's being removed by the CF worker anyways. This is dead code now.

We are not injecting `readthedocs-doc-embed.js` anymore and it's being removed
by the CF worker anyways. This is dead code now.
@humitos humitos requested a review from a team as a code owner November 11, 2024 14:55
@humitos humitos requested a review from agjohnson November 11, 2024 14:55
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just to clarify, this code isn't used anymore as even if projects still have this old include, our addons injection is removing the script anyways. Is that the assumption here? This seems good if so.

@humitos
Copy link
Member Author

humitos commented Nov 13, 2024

this code isn't used anymore as even if projects still have this old include, our addons injection is removing the script anyways. Is that the assumption here?

Yes.

@humitos humitos merged commit 3039290 into main Nov 13, 2024
4 checks passed
@humitos humitos deleted the humitos/remove-check-old-integration branch November 13, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants