Break out Addons injection module to own repository #226
Comments
agjohnson
added
Improvement
agjohnson
changed the title
We should still figure out moving these files in - #226
|
I'm not opposed to move it to its own repository, but I wanted to note the work required won't be trivial. I've put it in I'd propose starting by adding whatever is needed to run/write tests into this common repository first and grow from there if it's required, instead of the other way around.
I'm not worried about this. I see this script more as internal ops than user exposed. I'm fine if it's not super discoverable. In fact, it was originally inside ops but I had to move it because of the sharing between repositories needs. |
We also check out
This is already happening in #227 |
* Move addons injection files into package structure We should still figure out moving these files in - #226 * Add supplemental files to support updated addons injection module * Update injection script * Fix issues with response return order If `Response.clone()` is used without `await` the resulting instance has missing attributes, like `url = null`. The docs do not indicate that `clone()` is async however, so it's not clear why this is required. With this, and more careful response instance usage, most of the cases of dangling, unused, cloned responses have been removed. Now, any response that is used is cloned right as we use it and evaluate the body. This is important, as `response.body` is ultimately what causes the request to buffer. * Update throw debug header * Add more comments on response cloning * Bump up conditional for debug error throw * Test more response header passthrough * Add test for build.commands builds * Add path to wrangler build context * Fix wrangler path in docker compose * Increase logging on wrangler
While we use the module directly here in local development, it feels very hidden and disconnected from the rest of Addons. Users looking to report issues with the injection are probably looking at our main repository or the Addons repository. This module might be better authored and maintained in one of those locations instead.
I encountered this wanting to add tests to the script
It seems like we'd need:
${PWD}/${RTDDEV_PATH_ADDONS:-../addons}:/usr/src/app/checkouts/addonssimilar to other repo reuseThe text was updated successfully, but these errors were encountered: