Build director: define the environment just once for a set of cmds

readthedocs · Mar 16, 2022 · b4739fd · b4739fd
1 parent ade425d
commit b4739fd
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/readthedocs/doc_builder/director.py b/readthedocs/doc_builder/director.py
@@ -298,11 +298,12 @@ def run_build_job(self, job):
             return
 
         cwd = self.data.project.checkout_path(self.data.version.slug)
+        environment = self.vcs_environment
+        if job not in ("pre_checkout", "post_checkout"):
+            environment = self.build_environment
+
         commands = getattr(self.data.config.build.jobs, job, [])
         for command in commands:
-            environment = self.vcs_environment
-            if job not in ("pre_checkout", "post_checkout"):
-                environment = self.build_environment
             environment.run(*command.split(), escape_command=False, cwd=cwd)
 
     # Helpers