Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout menu not working #10955

Closed
cosmicBboy opened this issue Dec 15, 2023 · 2 comments
Closed

Flyout menu not working #10955

cosmicBboy opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@cosmicBboy
Copy link

cosmicBboy commented Dec 15, 2023

Details

Using the custom build commands readthedocs config key.

Expected Result

Expecting to see the readthedocs flyout menu on the bottom right. This was showing up correctly last week, even older builds that showed it correctly are no longer working.

Screenshot 2023-12-15 at 2 22 33 PM

Actual Result

It's blank, cannot find the inserted RTD footer flyout menu.

@humitos
Copy link
Member

humitos commented Dec 18, 2023

Thanks for reporting this. It's a bug in our side. The request to https://flyte-next.readthedocs.io/_/addons/?client-version=0.9.1&api-version=0 is returning 400. This is because it should include ?project-slug=flyte-next&version-slug=latest.

They are not included in the request because the meta HTML element with this data are not present in the page. I'll take a deeper look to understand why this is happening.

@humitos humitos self-assigned this Dec 18, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Dec 18, 2023
@humitos
Copy link
Member

humitos commented Dec 18, 2023

@cosmicBboy I found the issue and I fixed it. It's working now. It was an issue in our Cloudflare Worker that it was not injecting the meta HTML elements required for this. Please, confirm if it's working as expecting.

@humitos humitos closed this as completed Dec 18, 2023
@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Archived in project
Development

No branches or pull requests

2 participants