-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use experimental readthedocs build.commands config #4606
Conversation
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4606 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 622 622
Lines 52682 52682
=======================================
+ Hits 31102 31103 +1
+ Misses 19098 19097 -1
Partials 2482 2482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@thomasjpfan I opted for your solution to this, because readthedocs adds additional configuration to the user-supplied |
This PR changes the monodocs readthedocs config so that it uses the customizeable readthedocs build steps instead of the experimental
build.commands
config key. This is because there are some issues with correctly rendering the readthedocs flyout menu: readthedocs/readthedocs.org#10955Preview: https://flyte-next.readthedocs.io/en/monodocs-readthedocs-config/
vs.
https://flyte-next.readthedocs.io/en/latest/ (readthedocs inserted dropdown is missing)