Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fail builds if there is no index.html in the output dir #10550

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 19, 2023

We announced we deprecated this in readthedocs/blog#230 and we already contacted the users to warn about this.

This PR has to be merged after July 25th, 2023 and it has to be deployed on August 1st.

Closes #1800

We announced we deprecated this in readthedocs/blog#230
and we already contacted the users to warn about this.

This PR has to be merged after July 25th, 2023 and it has to be deployed on
August 1st.

Closes #1800
@humitos humitos added the Status: blocked Issue is blocked on another issue label Jul 19, 2023
@humitos humitos requested a review from a team as a code owner July 19, 2023 15:33
@humitos humitos requested a review from ericholscher July 19, 2023 15:33
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏲️

@ericholscher
Copy link
Member

@humitos went to merge this but it has a failing test. Will hold off for now 👍

@humitos humitos removed the Status: blocked Issue is blocked on another issue label Jul 26, 2023
@humitos humitos enabled auto-merge (squash) July 26, 2023 11:20
@humitos humitos merged commit 31bd5ad into main Jul 26, 2023
@humitos humitos deleted the humitos/fail-builds-with-no-index-html branch July 26, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn or Fail build if there is no index.html generated
2 participants