Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: codify browndates for "no config file deprecation" #10612

Merged
merged 12 commits into from
Aug 9, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 8, 2023

Follows https://github.com/readthedocs/blog/pull/233/files#r1283479184

This way, we don't have to enable anything manually.
These dates are already communicated to users and will be automatically applied.

humitos and others added 11 commits August 1, 2023 16:15
Define a weekly task to communicate our users about the deprecation of
`build.image` using the deprecation plan we used for the configuration file v2
as well.

- 3 brownout days
- final removal date on October 2nd
- weekly onsite/email notification on Wednesday at 11:15 CEST (around 3.5k projects affected)
- allow to opt-out from these emails
- feature flag for brownout days
- build detail's page notification

Related:
* readthedocs/meta#48
* #10354
* #10587
Define a weekly task to communicate our users about the deprecation of
`build.image` using the deprecation plan we used for the configuration file v2
as well.

- 3 brownout days
- final removal date on October 2nd
- weekly onsite/email notification on Wednesday at 11:15 CEST (around ~22k projects affected)
- allow to opt-out from these emails
- feature flag for brownout days
- build detail's page notification

Related:
* readthedocs/meta#48
* #10354
* #10587
…:readthedocs/readthedocs.org into humitos/deprecate-build-image-config-key
Co-authored-by: Anthony <[email protected]>
Co-authored-by: Eric Holscher <[email protected]>
Follows https://github.com/readthedocs/blog/pull/233/files#r1283479184

This way, we don't have to enable anything manually.
These dates are already communicated to users and will be automatically applied.
@humitos humitos requested a review from ericholscher August 8, 2023 16:05
@humitos humitos requested a review from a team as a code owner August 8, 2023 16:05
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! 👍

We should follow this pattern for all the deprecations 🤔

Base automatically changed from humitos/deprecate-build-image-config-key to main August 9, 2023 08:49
@humitos humitos requested a review from a team as a code owner August 9, 2023 08:49
@humitos humitos requested a review from agjohnson August 9, 2023 08:49
@humitos humitos enabled auto-merge (squash) August 9, 2023 08:57
@humitos humitos merged commit 18889f0 into main Aug 9, 2023
@humitos humitos deleted the humitos/deprecation-config-file-browndates branch August 9, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants