-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx: use html_baseurl for setting the canonical URL #7540
Conversation
Fix #82 Ref #83 We need to release the extension first, make sure all builds are using that version and then release readthedocs/readthedocs.org#7540
We need to merge and release readthedocs/readthedocs-sphinx-ext#83 first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- we should probably deprecate the canonical setting at some point, if we have a good way for users to set it.
Fix #82 Ref #83 We need to release the extension first, make sure all builds are using that version and then release readthedocs/readthedocs.org#7540
We need to remove this flag before merging this, so all users have the latest version of our extension
I'll check how many projects we have with that flag |
32510fd
to
f45f9b8
Compare
.. _html_baseurl: https://www.sphinx-doc.org/page/usage/configuration.html#confval-html_baseurl | ||
|
||
If you are using :doc:`MkDocs </intro/getting-started-with-mkdocs>`, | ||
you can use the site_url_ setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not automatically support this at all for mkdocs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but we can do it if we want #4820 :)
This is also blocked on
|
Is there any news on this? |
f45f9b8
to
f6f36e8
Compare
We are already using the latest version of the rtd-sphinx-ext, but we still need to merge and release readthedocs/sphinx_rtd_theme#1003 first. |
Thanks for the update! |
A new release of the t heme is out, we can merge this now |
I've confirmed this is working now on a doc rebuild with our latest deploy. |
Fixes readthedocs/readthedocs-sphinx-ext#83