Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language clarity and fix typos in README #305

Merged
merged 15 commits into from
Nov 14, 2024

Conversation

ivan-borovets
Copy link
Contributor

I've fixed errors and improved wording in the README for better clarity.

Let me know if this looks good -- I'm happy to proceed with refining the rest of the documentation.

Copy link

@rasputyashka rasputyashka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В параграфе про Provider и provide, alias, decorate я ни в одной из версий не понял про что там вообще написано.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ivan-borovets ivan-borovets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your involvement. I look forward to more of your feedback!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@rasputyashka rasputyashka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better.

You don't need to ask for review one more time. I'm ok with this version.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Tishka17 Tishka17 merged commit 8950dd8 into reagento:develop Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants