Allow disabling validation on empty tags #497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty tags on decoders, and treat them as missing tags if encountered when validation is off.
…pply empty tag validation to a codec build-time property. note: no mechanism for setting this build-time property has been added yet.
…system property passed in to the codec generator
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artio-codecs/src/main/java/uk/co/real_logic/artio/dictionary/generation/CodecGenerator.java
Fixed
Show fixed
Hide fixed
…rs under JDK21. There are ways of solving this without the suppression, but they require more discussion and work: this is a good starting point for what's likely to be over-eager analysis for most use cases.
|
note: CI keeps failing on:
This test seems wildly intermittent at the moment, and is also failing on this test on master - so I would argue this shouldn't be a blocker to merging? However: we're not getting any CI failures that can be attributed to this change, as far as I can see. |
|
Is this going to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are encountering situations where we're being sent FIX messages with empty tags (eg |448=|). Currently, this fails validation.
Whilst this is clearly invalid FIX, we can't legislate for what our counterparties send us: we've had multiple counterparties send us malformed FIX in this way. It would be nice to be able to, instead of failing on such messages, instead to treat these tags as missing (still triggering required fields validation if the field is required).
This change replicates the approach taken to other settings allowing enabling/disabling of validations, and includes a minimal test to show that the messages pass validation with absent fields when this specific validation is disabled.