Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl, and externalize initial ConnectionId to EngineConfiguration #500

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl, and externalize initial ConnectionId to EngineConfiguration #500

wants to merge 12 commits into from

Conversation

miketwk
Copy link

@miketwk miketwk commented Jan 4, 2024

As Captioned.

@miketwk
Copy link
Author

miketwk commented Jan 4, 2024

Don't instantiate String for each method:
localCompId(), localSubId() and remoteCompId()

miketwk
miketwk commented Mar 21, 2024
View reviewed changes
Copy link
Author

@miketwk miketwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can set initial ConnectionId in EngineConfiguration, so that it is deterministic.

@miketwk miketwk changed the title gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl and Mar 21, 2024
@miketwk miketwk changed the title gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl and gc3 for class SenderAndTargetSessionIdStrategy.CompositeKeyImpl and SenderTargetAndSubSessionIdStrategy.CompositeKeyImpl, and externalize initial ConnectionId to EngineConfiguration Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miketwk