[Go] SBE implementation in Go using flyweights #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanf
changed the title
|
@ethanf There are merge conflicts which prevent this PR from being merged. |
ethanf
force-pushed
the
go-flyweight
branch
from
c67db61
to
1c8d115
Compare
To generate flyweights instead of structs, set the following flag: ``` sbe.go.generate.generate.flyweights=true ```
ethanf
force-pushed
the
go-flyweight
branch
from
2fd7f99
to
67164ae
Compare
This generates flyweights in the sbe-tool build for use in the otf library.
@vyazelenko Merge conflicts are fixed up and tests are passing again. The go codebase needs to be modernized to use go modules, which will simplify and speed up the tests. This is ready to merge and we're starting to use it in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #765. To generate flyweights instead of structs, set the following flag:
Includes OTF and JsonPrinter implementations for parity with other implementations.