Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBSDEF-13969] add delay in read/write path in SLTS #1

Open
wants to merge 8 commits into
base: release-objectscale-1.0
Choose a base branch
from
Open

[OBSDEF-13969] add delay in read/write path in SLTS #1

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f1d9f25
Log for system critical operations queue wait time, set the OPERATION…
Dec 30, 2021
a45298d
fix code style
Dec 30, 2021
2116293
fetch elapsed time only once
Dec 30, 2021
e2b7c21
change OPERATION_LOG_MAX_SIZE to trigger max trottling
Dec 31, 2021
dc69d41
Change OPERATION_LOG_MAX_SIZE to 50K, add configs to inject read/writ…
realAaronWu Jan 11, 2022
0ccbfe2
add logs
realAaronWu Jan 11, 2022
fc0e04f
fix code style
realAaronWu Jan 11, 2022
8d9a3d1
use composeAsync in delay execution
realAaronWu Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...entstore/server/src/main/java/io/pravega/segmentstore/server/logs/OperationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,9 @@ private void processOperations(Queue<CompletableOperation> operations) {
CompletableOperation o = operations.poll();
this.metrics.operationQueueWaitTime(o.getTimer().getElapsedMillis());
try {
if (o.getOperation().getDesiredPriority() != null && o.getOperation().getDesiredPriority().isThrottlingExempt()) {
realAaronWu marked this conversation as resolved.
Show resolved Hide resolved
log.debug("queue wait time for critical operation {} is {}", o.getOperation(), o.getTimer().getElapsedMillis());
}
processOperation(o);
this.state.addPending(o);
count++;
Expand Down
2 changes: 1 addition & 1 deletion ...ntstore/server/src/main/java/io/pravega/segmentstore/server/logs/ThrottlerCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ThrottlerCalculator {
* Maximum size (in number of operations) of the OperationLog, above which maximum throttling will be applied.
*/
@VisibleForTesting
static final int OPERATION_LOG_MAX_SIZE = 1_000_000;
static final int OPERATION_LOG_MAX_SIZE = 50_000;
realAaronWu marked this conversation as resolved.
Show resolved Hide resolved
/**
* Desired size (in number of operations) of the OperationLog, above which a gradual throttling will begin.
*/
Expand Down