Emit the correct instruction for add_row_with_key(none) #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add_row_with_key instruction can't express a null int key, so instead we emit a row insert plus set null. This needs to set the variant as SetUnique for sync to handle this properly.
kspangsege
approved these changes
Jan 25, 2019
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
|
This PR made src/external/pegtl go back in time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_row_with_key instruction can't express a null int key, so instead we emit a row insert plus set null. This needs to set the variant as SetUnique for sync to handle this properly.
I don't think this bug has any observable effects for a non-sync realm so there's nothing to test here.