-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change string sort order #6406
Change string sort order #6406
Conversation
@ironage perhaps you can rebase this once we get master merged into next-major. The "delete some obsolete cruft" is now in master. |
I will make the merge into next-major once we have a new release. |
I will leave this as a draft until it is rebased to include #5662. Additionally, we will need server changes to support the new RQL syntax before releasing this. That is tracked in https://jira.mongodb.org/browse/BAAS-20265. |
Partially based on 5f2dda1 Delete some obsolete cruft set_string_compare_method() and everyhing related to it has never actually been used by any SDK, and is not really the correct solution to the problem anyway.
test migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ironage can this somehow be divided in two: One PR handling the changes to the query system and one handling the changes to the index? The one handling the index should also include upgrade logic and test cases for that. When you write the upgrade tests, you can create the input files and test case on the branch je/upgrade-from-23-tests
.
I will split this up. @jedelbo I cannot find the branch |
This implements option 3 from #6118
Set<StringData>
andSet<Mixed>
(with strings) and all string indexes have a new structure.The first commit in this PR is a cherry-pick of #5662 because otherwise all this will conflict in a difficult way.☑️ ToDos