Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2221 fix RQL BETWEEN regression for properties over links #7965

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Aug 7, 2024

Introduced in #7785. The between node only handles a single column, not a link chain, so we should check this before using the optimized query node.

Replaces #7940
Fixes #7935

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

Pull Request Test Coverage Report for Build james.stone_584

Details

  • 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.113%

Files with Coverage Reduction New Missed Lines %
src/realm/array_backlink.cpp 1 91.38%
src/realm/dictionary.cpp 1 85.16%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/noinst/server/server.cpp 1 74.02%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
test/fuzz_group.cpp 2 54.86%
test/object-store/sync/flx_sync.cpp 2 98.35%
src/realm/sync/client.cpp 3 90.96%
test/test_thread.cpp 3 66.14%
Totals Coverage Status
Change from base Build 2548: 0.03%
Covered Lines: 217072
Relevant Lines: 238246

💛 - Coveralls

@ironage
Copy link
Contributor Author

ironage commented Aug 8, 2024

CI failure was a system issue "[2024/08/07 12:05:22.852] error: unexpected service error: The Xcode build system has crashed. Build again to continue."

@ironage ironage merged commit 430a044 into master Aug 8, 2024
47 of 49 checks passed
@ironage ironage deleted the js/between-over-links branch August 8, 2024 16:17
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
@nicola-cab
Copy link
Member

@jedelbo @ironage I suspect that range queries over links will be quite slow in case the array is compressed. I'll add a benchmark to verify this.

@ironage
Copy link
Contributor Author

ironage commented Aug 12, 2024

@nicola-cab you are welcome to make a benchmark. The specialized BetweenNode won't work because the links could point to any array index at random. Not sure there will be any easy way to optimize this case.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Column key when using child properties with the BETWEEN keyword.
3 participants