Fix type definitions for authenticate #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
approved these changes
Aug 30, 2018
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ Server and open synchronized Realms (#1276). | |||
|
|
|||
| ### Bug fixes | |||
| * Removed a false negative warning when using `User.createConfiguration`. | |||
| * Fix the type definition for `User.authenticate`. | |||
There was a problem hiding this comment.
"Fix" -> "Fixed"
Is there an issue to refer to?
There was a problem hiding this comment.
Not really, I just ran into it while trying to use the API in studio
|
@nirinchev Please remember to add a T label and tick off the "Todo's". |
|
Done :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes # ???
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryTestsPublic documentation PR created or is not necessaryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
jsdoc files updatedChrome debug API is updated if API is available on React Native