Give the app a chance to disable analytics #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
kneth
approved these changes
Nov 13, 2018
kneth
reviewed
Nov 14, 2018
lib/submit-analytics.js
Outdated
| return null; | ||
| } | ||
| } | ||
| const { machineIdSync } = require("node-machine-id"); |
There was a problem hiding this comment.
What a nice simplification 😄
fealebenpae
approved these changes
Nov 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
contextargument to distinguish between node.js and electron.new Buffercalls which are deprecated in node 10.Fixes #2107.
☑️ ToDos