Cleaning up console output from tests #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 3, 2019 14:07
kneth
approved these changes
Oct 3, 2019
bmunkholm
reviewed
Oct 3, 2019
bmunkholm
reviewed
Oct 3, 2019
bmunkholm
reviewed
Oct 3, 2019
Co-Authored-By: Brian Munkholm <[email protected]>
Co-Authored-By: Brian Munkholm <[email protected]>
tgoyne
approved these changes
Oct 3, 2019
|
The failing tests looks like a brittle test harness to me:
|
|
@kraenhansen yeah. lets merge it |
kraenhansen
pushed a commit
that referenced
this pull request
Oct 4, 2019
* Clearing the default Jasmin reporters removes dots * Removed setLogLevel calls from tests * Removed excessive logging * Removed setLogger call from notifier tests * Setting up the Realm.Sync logger once * Using the "debug" logger in session tests * Adding missing dependencies * Documenting changes * Adding a release note * Fixed issues reported by Codacy * Apply suggestions from code review Co-Authored-By: Brian Munkholm <[email protected]> * Update tests/js/session-tests.js Co-Authored-By: Brian Munkholm <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I was getting back to Realm JS and got annoyed that the output from the tests are bloated with console.logs and output from the Realm JS client itself. It turned out the
Realm.Syncloggers got reset before each test executed (asRealm.clearTestStatewas called): To ensure the logger is restored, this PR monkey-patchesRealm.clearTestStateto reset the logger and log level to appropriate levels.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessary