Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SyncError.logUrl #5632

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Added SyncError.logUrl #5632

merged 5 commits into from
Mar 28, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Mar 24, 2023 •
edited
Loading

This PR exposes SyncError.logUrl, that contains the URL pointing to the server log related to the sync error.

As I was there:

  • I added docs for SyncError
  • I deprecated SyncError.isFatal, as it seems it's something that is only used internally and should probably not be exposed to SDK

This closes #5609

☑️ ToDos

  • 📝 Changelog entry
  • 🚦 Tests

@cla-bot cla-bot bot added the cla: yes label Mar 24, 2023
elle-j
elle-j reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Mainly wondering if the removal of isFatal is a breaking change we don't want to add now?

CHANGELOG.md Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/flexible.ts Outdated Show resolved Hide resolved
packages/realm/src/errors.ts Show resolved Hide resolved
packages/realm/src/errors.ts Show resolved Hide resolved
packages/realm/src/errors.ts Outdated Show resolved Hide resolved
@papafe papafe merged commit e41501e into main Mar 28, 2023
@papafe papafe deleted the fp/log-url branch March 28, 2023 07:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j left review comments

@kraenhansen kraenhansen kraenhansen approved these changes

@kneth kneth kneth approved these changes

@takameyer takameyer Awaiting requested review from takameyer

Assignees

@papafe papafe

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose log url in SyncError
4 participants
@papafe @kneth @kraenhansen @elle-j