Improving Electron tests #5738
Merged
Improving Electron tests #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
approved these changes
Apr 19, 2023
| @@ -39,11 +42,15 @@ app.on("ready", () => { | |||
| mainWindow = new BrowserWindow({ | |||
| show: false, | |||
| webPreferences: { | |||
| nodeIntegration: true, | |||
| contextIsolation: false, | |||
There was a problem hiding this comment.
Is false required for these tests (regarding the context isolation)?
Comment on lines
+16
to
+17
| "test:ci:main": "mocha-remote --reporter mocha-github-actions-reporter --id main tsx runner.ts main", | ||
| "test:ci:renderer": "mocha-remote --reporter mocha-github-actions-reporter --id renderer tsx runner.ts renderer", |
There was a problem hiding this comment.
Regarding the earlier issue we saw with including/excluding --prefix. Is it safe to not include that here?
| @@ -45,16 +45,16 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@realm/mocha-reporter": "*", | |||
| "cmake-js": "^6.1.0", | |||
There was a problem hiding this comment.
Is this replaced with something else or just not needed anymore?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Improves running the Electron tests: