Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Values of properties are replaced by default value when updating #6132

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Values of properties are replaced by default value when updating #6132

merged 4 commits into from
Sep 20, 2023

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Sep 14, 2023

What, How & Why?

This closes #6129

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@cla-bot cla-bot bot added the cla: yes label Sep 14, 2023
@kneth kneth requested a review from elle-j September 14, 2023 16:08
@kneth kneth mentioned this pull request Sep 14, 2023
Closed
@coveralls-official
Copy link

coveralls-official bot commented Sep 15, 2023 •
edited
Loading

Coverage Status

coverage: 85.314% (+0.004%) from 85.31% when pulling 4aa9a9d on kneth/bug/create-with-defaults into b807f3b on main.

elle-j
elle-j approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

CHANGELOG.md Outdated Show resolved Hide resolved
@kneth kneth force-pushed the kneth/bug/create-with-defaults branch from 31fe312 to 028712c Compare September 20, 2023 16:36
@kneth kneth merged commit f3fe1d4 into main Sep 20, 2023
32 checks passed
@kneth kneth deleted the kneth/bug/create-with-defaults branch September 20, 2023 18:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

@elle-j elle-j elle-j approved these changes

@takameyer takameyer Awaiting requested review from takameyer

Assignees

@kneth kneth

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Values are replaces by default value when updating
3 participants
@kneth @kraenhansen @elle-j