Fix setting an object with an embedded object property to null
#6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
commented
Dec 1, 2023
Comment on lines
104
to
111
| // Asking for the toBinding will create the object and link it to the parent in one operation. | ||
| // Thus, no need to actually set the value on the `obj` unless it's an optional null value. | ||
| const bindingValue = toBinding(value, { createObj: () => [obj.createAndSetLinkedObject(columnKey), true] }); | ||
| // No need to destructure `optional` and check that it's `true` in this condition | ||
| // as trying to set a non-optional value to null will fail at an earlier stage. | ||
| if (bindingValue === null) { | ||
| obj.setAny(columnKey, bindingValue); | ||
| } |
There was a problem hiding this comment.
The call to toBinding() will in turn call nullPassthrough(), resulting in toBinding() returning null without calling into Core. For other non-null and non-undefined values, the embedded object will be created during that call.
kneth
approved these changes
Dec 4, 2023
Comment on lines
104
to
111
| // Asking for the toBinding will create the object and link it to the parent in one operation. | ||
| // Thus, no need to actually set the value on the `obj` unless it's an optional null value. | ||
| const bindingValue = toBinding(value, { createObj: () => [obj.createAndSetLinkedObject(columnKey), true] }); | ||
| // No need to destructure `optional` and check that it's `true` in this condition | ||
| // as trying to set a non-optional value to null will fail at an earlier stage. | ||
| if (bindingValue === null) { | ||
| obj.setAny(columnKey, bindingValue); | ||
| } |
kraenhansen
reviewed
Dec 4, 2023
kraenhansen
reviewed
Dec 4, 2023
kraenhansen
approved these changes
Dec 4, 2023
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
…lm#6295) * Update DB obj when embedded prop is set to null. * Add tests. * Add CHANGELOG entry. * Update inline comment. * Add tests using 'UpdateMode'. * Extract common logic to separate function to make the tests more focused.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Updating an object's property whose value was an embedded object did not call into Core to update the underlying object when the new value was
nullorundefined.This closes #6280
☑️ ToDos