NamedArgumentForDataProviderRector changes data providers that it doesn't need to

[gnutix]

Hey ya,

Let me know if I'm wrong, but I think this kind of change is unnecessary (I tried reverting the change and PHPUnit does not report any deprecation) :

While this one is probably necessary, as there cannot be un-named arguments after named arguments (yet PHPUnit does not report the deprecation either... probably a miss on their side) :

It doesn't really hurt though, so I get it if you don't want to fix it. But it might generate quite of lot of useless diff for some projects, which could be avoided.

gnutix

[TomasVotruba]

Hey, I agree. There should not be changed.
Could you send PR with fix and test?

[gnutix]

Sorry, too much on my plate these days.

[TomasVotruba]

No worries. The rule works as intended, it's just an optional way to use a feature: sebastianbergmann/phpunit#5225

I'll remove the rule from main set, so it's not enforcing an optional feature.