-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow providing named arguments from a data provider #5225
Allow providing named arguments from a data provider #5225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
=========================================
Coverage 89.40% 89.40%
Complexity 6425 6425
=========================================
Files 683 683
Lines 20405 20405
=========================================
Hits 18243 18243
Misses 2162 2162 ☔ View full report in Codecov by Sentry. |
d7eeec1
to
800b79a
Compare
Hey there! Was wondering if there was anything left for me to do that can help getting this reviewed and/or merged? |
800b79a
to
cb71af2
Compare
cb71af2
to
c9a6f74
Compare
Just rebased this onto |
This will not go into PHPUnit 10.1, sorry. |
I understand that it was a bit of a short time to get it in. Is there anything I can do to help it go into the next minor version? |
c9a6f74
to
7132f53
Compare
4f4fb45
to
d4a9a6e
Compare
d4a9a6e
to
b926904
Compare
b926904
to
0f81bc5
Compare
Rebased this on Note: for anyone subscribed interested, testing these changes in your local setup to ensure everything works fine on your end and then leaving a review might be helpful in landing this PR. |
0f81bc5
to
57f471f
Compare
08dc555
to
63591f3
Compare
57f471f
to
dafdc71
Compare
Yes, please send a pull request for test(s) for the unsupported case(s). Thanks! |
Resolves #5150
This PR aims to allow passing named arguments from a data provider, to have more flexibility in re-ordering arguments and skipping optional ones without having to provide a default value.
Note 1: I was not entirely sure on where to put the test; if there is a more suitable location to add this, let me know!
Note 2: Combining named arguments with input from a dependency is not supported, as providing positional arguments after named ones in an array is not supported, and data provider arguments will go first as per doc description. I could not find a test to ensure this behavior, so made jnoordsij@ac028c8 this PR doesn't break existing behavior. I also created jnoordsij@f7e28c4 to demonstrate the unsupported case. If wanted, I can add those tests to this PR or a new PR.