Create a rector rule that will rename the array keys from the PHPUnit Dataprovider #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DataProvider to the argument name of the called test method to be prepared for the usage of named arguments in PHPUnit 11. This was already deprecated in PHPUnit 10.5
samsonasik
reviewed
May 21, 2024
samsonasik
reviewed
May 21, 2024
rules/PHPUnit110/Rector/Class_/NamedArgumentForDataProviderRector.php
Outdated
Show resolved
Hide resolved
|
Please run: To fix CI |
Co-authored-by: Abdul Malik Ikhsan <[email protected]>
marcelthole
force-pushed
the
change-dataprovider-namedarguments
branch
from
1aed14a to
6a5acb0
Compare
|
Hey, |
samsonasik
approved these changes
Jun 3, 2024
samsonasik
reviewed
Jun 3, 2024
| use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | ||
|
|
||
| /** | ||
| * @see \Rector\PHPUnit\Tests\PHPUnit100\Rector\Class_\StaticDataProviderClassMethodRector\StaticDataProviderClassMethodRectorTest |
There was a problem hiding this comment.
could you add @see https://github.com/sebastianbergmann/phpunit ... , which exact part to exact changelog/documentation for this change?
There was a problem hiding this comment.
yes, added the changelog and the PR
samsonasik
reviewed
Jun 3, 2024
Comment on lines
129
to
132
| $wasChanged = $this->refactorArrayKey( | ||
| $dataProviderArrayItem, | ||
| $namedArgumentsFromTestClass | ||
| ) || $wasChanged; |
There was a problem hiding this comment.
it can be more readable with:
if ($this->refactorArrayKey(
$dataProviderArrayItem,
$namedArgumentsFromTestClass
)) {
$wasChanged = true;
}
|
LGTM, @TomasVotruba let's merge it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a rector rule that will rename the array keys from the PHPUnit Dataprovider to the argument name of the called test method to be prepared for the usage of named arguments in PHPUnit 11. This was already deprecated in PHPUnit 10.5
I think this is a risky rule because you could use the same dataProvider for multiple tests and the name of the arguments could be differ between the methods. (That's the point why i didn't added it to a new PHPUnit110 list)
Maybe it make sense to add an configurable option to remove the array key names completly to not use the named argument feature at all?