Fix StrictArrayParamDimFetchRector for string access

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/twice_same_type.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class TwiceSameType
+{
+    public function getData()
+    {
+        if (mt_rand(0, 100)) {
+            return $this->getNumber(100);
+        }
+
+        return $this->getNumber(10);
+    }
+
+    private function getNumber(int $value): int
+    {
+        return $value;
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_possible_string.php.inc

@@ -4,10 +4,14 @@ namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFet
 
 final class SkipPossibleString
 {
-    public function resolve($item)
+    public function resolve($number)
     {
-        $item .= 'yes';
+        $check = 0;
 
-        return $item[0];
+        for ($i = 0; $i < strlen($number); $i++) {
+            $check = $number[$i];
+        }
+
+        return $check;
     }
 }

rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php

@@ -80,7 +80,6 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $hasChanged = false;
-
         if ($node instanceof ClassMethod && $this->parentClassMethodTypeOverrideGuard->hasParentClassMethod($node)) {
             return null;
         }
@@ -136,6 +135,10 @@ private function isParamAccessedArrayDimFetch(Param $param, ClassMethod|Function
                 return null;
             }
 
+            if (! $node->dim instanceof Expr) {
+                return null;
+            }
+
             if (! $node->var instanceof Variable) {
                 return null;
             }
@@ -150,6 +153,12 @@ private function isParamAccessedArrayDimFetch(Param $param, ClassMethod|Function
                 return null;
             }
 
+            // skip integer in possibly string type as string can be accessed via int
+            $dimType = $this->getType($node->dim);
+            if ($dimType->isInteger()->yes() && $variableType->isString()->maybe()) {
+                return null;
+            }
+
             $isParamAccessedArrayDimFetch = true;
             return null;
         });