[Downgrade PHP 7.4] Add false to downgraded typed property (#1596)

Co-authored-by: Ondrej Mirtes <[email protected]>
Co-authored-by: GitHub Action <[email protected]>

packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php

@@ -42,10 +42,10 @@ public function createMixedPassedOrUnionTypeAndKeepConstant(array $types): Type
     /**
      * @param Type[] $types
      */
-    public function createMixedPassedOrUnionType(array $types): Type
+    public function createMixedPassedOrUnionType(array $types, bool $keepConstantTypes = false): Type
     {
         $types = $this->unwrapUnionedTypes($types);
-        $types = $this->uniquateTypes($types);
+        $types = $this->uniquateTypes($types, $keepConstantTypes);
 
         return $this->createUnionOrSingleType($types);
     }

packages/StaticTypeMapper/PhpParser/UnionTypeNodeMapper.php

@@ -45,6 +45,6 @@ public function mapToPHPStan(Node $node): Type
             $types[] = $this->phpParserNodeMapper->mapToPHPStanType($unionedType);
         }
 
-        return $this->typeFactory->createMixedPassedOrUnionType($types);
+        return $this->typeFactory->createMixedPassedOrUnionType($types, true);
     }
 }

rules-tests/DowngradePhp74/Rector/Property/DowngradeTypedPropertyRector/Fixture/false_type.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector\Fixture;
+
+class Foo
+{
+
+    private Foo|Bar|false $prop;
+
+}
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector\Fixture;
+
+class Foo
+{
+
+    /**
+     * @var \Rector\Tests\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector\Fixture\Bar|\Rector\Tests\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector\Fixture\Foo|false
+     */
+    private $prop;
+
+}
+?>

rules-tests/DowngradePhp80/Rector/Property/DowngradeUnionTypeTypedPropertyRector/Fixture/false_type.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\Property\DowngradeUnionTypeTypedPropertyRector\Fixture;
+
+class Foo
+{
+
+    private Foo|Bar|false $prop;
+
+}
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\Property\DowngradeUnionTypeTypedPropertyRector\Fixture;
+
+class Foo
+{
+
+    /**
+     * @var \Rector\Tests\DowngradePhp80\Rector\Property\DowngradeUnionTypeTypedPropertyRector\Fixture\Bar|\Rector\Tests\DowngradePhp80\Rector\Property\DowngradeUnionTypeTypedPropertyRector\Fixture\Foo|false
+     */
+    private $prop;
+
+}
+?>

rules-tests/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector/FixtureForPhp81/do_not_crash_on_numeric_string_no_return_declaration.php.inc

@@ -34,4 +34,4 @@ class DoNotCrashOnNumericStringNoReturnDeclaration
     }
 }
 
-?>
+?>