note, down timeout to 60 seconds to spot bottle necks sooner

rectorphp · Dec 31, 2023 · 6700e1c · 6700e1c
1 parent 47b6389
commit 6700e1c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/Config/RectorConfig.php b/packages/Config/RectorConfig.php
@@ -83,10 +83,14 @@ public function enableCollectors(): void
         SimpleParameterProvider::setParameter(Option::COLLECTORS, true);
     }
 
-    public function parallel(int $seconds = 120, int $maxNumberOfProcess = 32, int $jobSize = 20): void
+    /**
+     * Defaults in sync with https://phpstan.org/config-reference#parallel-processing
+     * as we run PHPStan as well
+     */
+    public function parallel(int $processTimeout = 60, int $maxNumberOfProcess = 32, int $jobSize = 20): void
     {
         SimpleParameterProvider::setParameter(Option::PARALLEL, true);
-        SimpleParameterProvider::setParameter(Option::PARALLEL_JOB_TIMEOUT_IN_SECONDS, $seconds);
+        SimpleParameterProvider::setParameter(Option::PARALLEL_JOB_TIMEOUT_IN_SECONDS, $processTimeout);
         SimpleParameterProvider::setParameter(Option::PARALLEL_MAX_NUMBER_OF_PROCESSES, $maxNumberOfProcess);
         SimpleParameterProvider::setParameter(Option::PARALLEL_JOB_SIZE, $jobSize);
     }

diff --git a/packages/Validation/RectorConfigValidator.php b/packages/Validation/RectorConfigValidator.php
@@ -36,12 +36,15 @@ public static function ensureRectorRulesExist(array $skip): void
                 $nonExistingRules[] = $key;
                 continue;
             }
+
             if (! self::isRectorClassValue($value)) {
                 continue;
             }
+
             if (class_exists($value)) {
                 continue;
             }
+
             $nonExistingRules[] = $value;
         }