[TypeDeclaration] optionally only add types for hard coded return values in ReturnTypeFromStrictScalarReturnExprRector

[RobertMe]

Supersedes #5361, relates to rectorphp/rector#8362

[RobertMe]

Build failure seems to be unrelated (/incidental hickup by composer while downloading a package?)

[RobertMe]

Ran it on my actual work project. And well, it works 😃

Did it in two stages, as desired. So first with the hard_coded_only option enabled which did precisely what I wanted it to do (only add return types to methods with hardcoded return true; / return 10; / return 'some string';). Followed by a second run without the option set which added return type hints for the more "complex" returns (based on strict method calls, string concats, ...), on top of it. And to validate everything still properly worked reverted the changes to Rector (the rule and analyzer) and ran it again, which didn't make any additional changes.

[TomasVotruba]

@RobertMe Thanks for fast work. I drifted my attention away over holidays and only got to see this one. Could you rebase the PR?

cc @samsonasik Could you review this one?

[RobertMe]

@TomasVotruba , sure, rebased.

I don't mind it took a bit longer, it's the holiday season anyway and everybody needs some rest 😄

[samsonasik]

Looking good 👍

[samsonasik]

Thank you @RobertMe

[samsonasik]

This need false per default value for consistency

[RobertMe]

Yip, and the example output was wrong as well 🙈 Noticed that myself too when once more going over your comments

[RobertMe]

Thank you @RobertMe

Thank you @samsonasik for the review and merging 😃. You were even quicker with merging then I was going through the comments (and then finding the "issue" with the config example and having to fix it once more).

[TomasVotruba]

Thank you @RobertMe 👏

[TomasVotruba]

Hey @RobertMe , just a follow up. In the end we've split rule into 6 standalones ones:

• each for bool, string and int/float
• one for real scalar values (e.g. return "word";), as it should be, 2nd for strict types (e.g. return (string) $value;)

See #6113

Thanks for feedback 👍