[Php80][CodeQuality] Handle crash on ChangeSwitchToMatchRector + TernaryFalseExpressionToIfRector on under if else #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aryFalseExpressionToIfRector on under if else
|
Fixed 🎉 /cc @noother |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
commented
Jan 8, 2024
Comment on lines
+131
to
+132
| foreach ($node->stmts as $stmt) { | ||
| $stmt->setAttribute(AttributeKey::SCOPE, $mutatingScope); |
There was a problem hiding this comment.
Using $this->nodeScopeResolver->processNodes($node->stmts, $mutatingScope, $nodeCallback); may probably better for reliable enter scope.
I will check if that may cause some performance hit.
There was a problem hiding this comment.
Testing manually with multi stmts, the scope seems linear, so it seems ok (for now), note to myself: it may need to revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8393
Ref https://getrector.com/demo/db2e7515-e2a2-42f3-9935-4497066b40f0