Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Move isWindows() method from AbstractRectorTestCase to AbstractLazyTestCase #6715

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[DX] Move isWindows() method from AbstractRectorTestCase to AbstractLazyTestCase #6715

merged 2 commits into from
Feb 3, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Feb 3, 2025 •
edited
Loading

  • Move isWindows() method from AbstractRectorTestCase to AbstractLazyTestCase
  • Make use of this repetitive usage.
  • Skip symlink tested locally on windows 11 which unreliable with use the isWindows() method

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 4f54239 into main Feb 3, 2025
44 checks passed
@TomasVotruba
Copy link
Member

👍

@TomasVotruba TomasVotruba deleted the dx-move-is-windows branch February 3, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @staabm