Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Use exactly equal or append / file path check on RealpathMatcher #6716

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Feb 3, 2025

Remove unnecessary IO for is_file() and is_dir(), as realpath() already validated before,

$realPathMatchingPath = realpath($matchingPath);
if ($realPathMatchingPath === false) {
return false;
}
$realpathFilePath = realpath($filePath);
if ($realpathFilePath === false) {
return false;
}

so just compare string equal or append with / suffix to file path.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 7f91068 into main Feb 3, 2025
44 checks passed
@samsonasik samsonasik deleted the perf-exact-equal-append branch February 3, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant