Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rector does not refactor PHP8.3 ldap_connect deprecated signature #8358

Closed
scollovati opened this issue Dec 13, 2023 · 0 comments · Fixed by rectorphp/rector-src#5397
Closed
Labels

Comments

@scollovati
Copy link

scollovati commented Dec 13, 2023

Bug Report

Subject Details
Rector v0.18.12
PHP 8.3.0

Rector does not refactor PHP8.3 ldap_connect deprecated signature. https://www.php.net/manual/en/migration83.deprecated.php#migration83.deprecated.ldap

Minimal PHP Code Causing Issue

$ldapconn = ldap_connect($ldapserver, $ldapport);

Rector config

    $rectorConfig->phpVersion(PhpVersion::PHP_83);

    $rectorConfig->paths([
        __DIR__ . '/src',
        __DIR__ . '/public'
    ]);


    $rectorConfig->sets([
        // run and fix, one by one
        LevelSetList::UP_TO_PHP_83,
        SetList::DEAD_CODE,
        SetList::CODE_QUALITY,
        SetList::CODING_STYLE,
        SetList::EARLY_RETURN,
        SetList::TYPE_DECLARATION,
    ]);

Expected Behaviour

Rector should merge the two parameters in a unique URI of the form ldap://hostname:port or ldaps://hostname:port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants