Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php83] Add CombineHostPortLdapUriRector #5397

Merged
merged 5 commits into from
Dec 27, 2023
Merged

[Php83] Add CombineHostPortLdapUriRector #5397

merged 5 commits into from
Dec 27, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 27, 2023 •
edited
Loading

@samsonasik samsonasik marked this pull request as draft December 27, 2023 17:48
@samsonasik samsonasik marked this pull request as ready for review December 27, 2023 18:05
@samsonasik
Copy link
Member Author

@scollovati this is the initial support for migrating deprecated use of 2nd arg on ldap_connect() :)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 109d734 into main Dec 27, 2023
42 checks passed
@TomasVotruba TomasVotruba deleted the php83-host-port branch December 27, 2023 22:01
@TomasVotruba
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rector does not refactor PHP8.3 ldap_connect deprecated signature
2 participants
@samsonasik @TomasVotruba