Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data missing from CSV incidents download #321

Open
jim-mcgowan opened this issue Jul 9, 2021 · 7 comments
Open

Data missing from CSV incidents download #321

jim-mcgowan opened this issue Jul 9, 2021 · 7 comments

Comments

@jim-mcgowan
Copy link
Member

When downloading data as a CSV from the More Incidents... page, the following fields (columns) aren't populated:

  • num_adults
  • num_children
  • num_families
  • assistance_given
  • incident_verified
  • dispatch_relayed
  • responders_identified
  • dat_on_scene
  • dat_departed_scene

GNY

@jim-mcgowan
Copy link
Member Author

@frankduncan: Now when I attempt to download incident data (via the Download CSV link), I get a small CSV file titled incidents.csv containing the following:

CSV

This remains urgent as Greater New York is trying to complete end-of-FY reporting.

Thanks!

@jim-mcgowan jim-mcgowan reopened this Jul 29, 2021
@frankduncan
Copy link
Contributor

It just worked for me, can you try again?

@jim-mcgowan
Copy link
Member Author

jim-mcgowan commented Jul 29, 2021

@frankduncan: I just tried downloading GNY data from July 2020 - July 2021 and I get the same problem. Interestingly, it takes 60 seconds from the time I click Download CSV to the when the file downloads (I timed it). Also, every time I try, the file overwrites the previous file in my downloads folder (rather than creating a new file).

@jim-mcgowan
Copy link
Member Author

@frankduncan: If this is a more involved fix, it can wait until tomorrow. I'll put off GNY for another day.

@frankduncan
Copy link
Contributor

Yeah, it's timing out. If you do only a month, it works. Something in the code I added to fix this issue (most likely iterating over the timeline for every incident a few times to get those dates) is making it slow down.

So yes, this a more involved fix.

@jim-mcgowan
Copy link
Member Author

@frankduncan: OK. Considering they want data back to January 1, 2018, I think we'll wait for the more involved fix (rather than do 43 individual downloads).

@frankduncan
Copy link
Contributor

I've pushed a fix that lets me get 6 months of data with no problem. Maybe it'll work for longer ones as well, but they may have to piece together a few sheets.

frankduncan pushed a commit that referenced this issue Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants