Expose an API to react-server-cli's startServer. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // before they get loaded. | ||
| const logging = require("react-server").logging, | ||
| logger = logging.getLogger(__LOGGER__), | ||
| start = require(".").start; |
There was a problem hiding this comment.
Annoying that renaming makes it look like the entire file is new. :(
So you don't have to look for yourself: this is one of the two lines changed in this file. I used "." so that it would be sure use the exposed API function.
There was a problem hiding this comment.
Happy to switch to ./index if you want. Felt slightly DRYer this way but slightly more confusing.
|
LGTM |
|
This is cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple export of the startServer API, as proposed in #33 and #50, so that servers can be started up programmatically.
I think it's probably also a good idea to expose the client compilation as an API to allow more flexibility, but I believe that's orthogonal to this PR.