Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dynamic config from process.env.REACT_SERVER_CONFIGS #871

Merged
merged 3 commits into from
Mar 9, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/guides/production.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ into your application. One example of the file `_configs/production/config.json
}
```

If dynamic config is preferred, just replace `config.json` with file `config.js`. One example of `config.js` might look like this:

```js
module.exports = {
APP_ENV: process.env.NODE_ENV === "production" ? "prod" : "dev",
MY_GLOBAL_VARIABLE: process.env.NODE_ENV === "production" ? "foo" : "bar"
}
```

To use these config variables inside your application, just use the `config()` function inside `react-server` and
you're all set! This works reliably on both server and client sides of the application--fully isomorphic!
Here's an example:
Expand Down
17 changes: 10 additions & 7 deletions packages/react-server/core/config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

/**
* Thin wrapper around the environment-specific configuration file
*/
Expand All @@ -10,13 +9,17 @@ if (SERVER_SIDE) {
module.exports = function () {
// only read out the config once, and then cache it. -sra.
if (null === config) {
/*eslint-disable no-process-env */

//eslint-disable-next-line no-process-env
if (process.env.REACT_SERVER_CONFIGS) {
var fs = require("fs");
/*eslint-disable no-process-env */
var configFile = fs.readFileSync(process.env.REACT_SERVER_CONFIGS + "/config.json");
/*eslint-disable no-process-env */
config = Object.freeze(JSON.parse(configFile));
var path = require('path');
//eslint-disable-next-line no-process-env
var configFilePath = process.env.REACT_SERVER_CONFIGS;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-disable in original code actually disable eslint check for all below code. So, I just update it with eslint-disable-next-line.

// Node.js tries to load `config.js` file first. If `config.js` doesn't exist, Node.js
// then try to load `config.json`.
configFilePath = path.join(process.cwd(), configFilePath + "/config");
config = Object.freeze(configFilePath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Object.freeze(require("configFilePath"))?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I had to add the Object.freeze and removed the require() part. Fixed!

} else {
config = Object.freeze({});
}
Expand Down