Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react-server-cli AVA test issues #876

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix react-server-cli AVA test issues #876

merged 1 commit into from
Feb 10, 2017

Conversation

drewpc
Copy link
Collaborator

@drewpc drewpc commented Feb 10, 2017

Addresses issues discussed here and, possibly, reasons why #871 is failing build.

  • Uses custom ports for the CLI tests
  • Tests additional edge case for stdout/stderr in case there are other errors in stderr that need to be displayed.

@drewpc
Fix the stdout/stderr assertions to work under more circumstances and…
21f743e 
… display errors even when using TAP. Modify the tests to use custom ports instead of the default 3000/3001.
@drewpc drewpc added the testing label Feb 10, 2017
@drewpc drewpc added this to the 0.6.1 milestone Feb 10, 2017
karlhorky
karlhorky approved these changes Feb 10, 2017
View reviewed changes
Copy link
Contributor

@karlhorky karlhorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Stable tests ftw!

@drewpc
Copy link
Collaborator Author

drewpc commented Feb 10, 2017 •
edited
Loading

@gigabo Because the build on master is failing right now, I'm going to approve & merge this PR right now without a maintainer's approval to see what's happening. If there's public outcry about it, let me know and I'll reverse it.

@drewpc drewpc merged commit 9611f41 into redfin:master Feb 10, 2017
@drewpc drewpc deleted the patch-fix-cli-ava-tests branch February 10, 2017 13:43
roblg
roblg reviewed Feb 10, 2017
View reviewed changes
Copy link
Member

@roblg roblg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactively approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblg roblg roblg left review comments

@karlhorky karlhorky karlhorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@drewpc @roblg @karlhorky