Combine task runner images into a single image #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbaird
force-pushed
the
combine-runner-images
branch
3 times, most recently
from
ab18a47
to
d9dc42b
Compare
I think we can get away with using the same image everywhere, so let's do that. This will also make it easier to build in Konflux since we can do it with a single component. Ref: https://issues.redhat.com/browse/RHTAP-3276
Make it easier to fully rebuild the dependencies locally if you want to do that, e.g. to get fresher ubi9 rpms.
This is nicer than setting it in the pre-init step and should work the same afaict.
I'm thinking this might help avoid some hard to debug problems or test breakages as we transition from multiple images to a single image. These extra tags can be removed in the near future.
simonbaird
force-pushed
the
combine-runner-images
branch
from
d9dc42b
to
28e86e0
Compare
|
I'm pretty confident to merge this soon (and fix any unexpected problems as needed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of separate, nearly identical, gitlab and github images, let's just use the same one for both.
See commit messages for details.
Ref: https://issues.redhat.com/browse/RHTAP-3276