Dockerfile: do not build the legacy binary #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container image is updated to avoid building the old binary and copying stuff that it is not required anymore. The "certsuite" binary is installed in "/usr/local/bin" so that it can be directly called. The GitHub workflows have been updated accordingly. An update in DCI and QE will be necessary as well.
|
from change #2181: |
Merged
2 tasks
|
/dci-rerun |
sebrandon1
approved these changes
Jun 20, 2024
rdavid
approved these changes
Jun 20, 2024
|
Please do not merge this change until this change in the collections is validated: redhatci/ansible-collection-redhatci-ocp#356, else DCI automation will be broken |
|
from change #2181: |
ramperher
approved these changes
Jun 20, 2024
jmontesi
merged commit 4895509
into
redhat-best-practices-for-k8s:main
17 of 25 checks passed
|
from change #2181: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-depends: redhatci/ansible-collection-redhatci-ocp#356
The container image is updated to avoid building the old binary and copying stuff that it is not required anymore.
The "certsuite" binary is installed in "/usr/local/bin" so that it can be directly called.
The GitHub workflows have been updated accordingly.
An update in DCI and QE will be necessary as well.